------------------------------------------------------------------------------
To reply, visit https://hellosplat.com/s/beanbag/tickets/4524/
------------------------------------------------------------------------------
New update by seb
For Beanbag, Inc. > Review Board > Ticket #4524
Reply:
Interestingly, we already have locally modified stylesheets. In particular
I had already patched the json style to implement the search API for a
different use case. So it was fairly straight-forward to take the JSON template
from
https://www.mercurial-scm.org/repo/hg/file/tip/mercurial/templates/json/map and
drop it into place in our server. I did have to patch it a little since the
utf8 filter isn't available in 3.7.
I can confirm that json search works (now looking slightly different from
my implementation, but that's ok) using a browser. The output of the log url
above however has not changed. The full URL btw was:
http://hg.terminals.taitradio.net:8005/TTDE/TestRepo/json-log/?rev=branch(.)
which of course is not accessible from outside our intranet.
However, none of this has changed the behaviour of RB. I suspect because,
looking at the original RB back-trace, RB is accessing HG using something like
the RL parameter ?api_format=json which as far as I can tell has no effect on
my mercurial 3.7. What's the difference between api_format=json and style=json?
Because the latter does work.
Upgrading the mercurial server would be a much bigger job then patching the
templates.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
