Comment #14 on issue 3045 by [email protected]: when updating new diff
on existing reviews on reviewboard server in clearcase source file revision
is not LATEST
http://code.google.com/p/reviewboard/issues/detail?id=3045
I have tried what you have suggested.
I have created a new review and published it.
The I have deleted the files ~/.post-review-cookies.txt and
~/.rbtools-cookies
When ran the update it is loading the diff but not showing it in the review
request.
This is the command output:
=======================================================================================
post-review -r "140"
--revision-range "/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/4;/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/5"
--debug
RBTools 0.5.2
Python 2.6.6 (r266:84292, Sep 11 2012, 08:34:23)
[GCC 4.4.6 20120305 (Red Hat 4.4.6-4)]
Running on Linux-2.6.32-220.el6.x86_64-x86_64-with-centos-6.2-Final
Home = /users/saarn
Current Directory = /vobs/build
Checking the repository type. Errors shown below are mostly harmless.
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Running: svn info build --non-interactive
DEBUG:root:Command exited with rc 1:
['svn', 'info', 'build', '--non-interactive']
svn: '.' is not a working copy
---
DEBUG:root:Checking for a Git repository...
DEBUG:root:Running: git rev-parse --git-dir
DEBUG:root:Command exited with rc 128: ['git', 'rev-parse', '--git-dir']
fatal: Not a git repository (or any of the parent directories): .git
---
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Checking for a Plastic repository...
DEBUG:root:Checking for a ClearCase repository...
DEBUG:root:Running: cleartool pwv -short
DEBUG:root:Running: diff --version
DEBUG:root:Running: cleartool lsview -full -properties -cview
DEBUG:root:Running: cleartool describe -short vob:.
DEBUG:root:Running: cleartool pwv -root
DEBUG:root:repository info: Path: /vobs/build, Base path: /vobs/build,
Supports changesets: False
Finished checking the repository type.
HTTP GETting api/info/
==> HTTP Authentication Required
Enter authorization information for "Web API" at review-board
Username: builder
Password:
DEBUG:root:Running: diff -uN
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/4
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/5
DEBUG:root:Command exited with rc 1:
['diff', '-uN', '/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/4', '/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/5']
---
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/4
2014-02-20 08:39:28.000000000 +0200
+++
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/5
2014-02-20 08:42:33.000000000 +0200
@@ -47,3 +47,5 @@
added by saar to test updating existing review
another diff first post
+
+This is the new line to be updated
---
DEBUG:root:Running: cleartool describe -fmt %On
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/4
DEBUG:root:Running: cleartool describe -fmt %On
/view/izabo.TestReviewBoard-saarn/vobs/build/tst/file@@/main/fortis/hamsa/izabo/TestReviewBoard/5
HTTP GETting api/
HTTP GETting http://review-board/api/info/
Using the new web API
HTTP GETting http://review-board/api/review-requests/140/
DEBUG:root:Running: cleartool lsvob -long /vobs/build
DEBUG:root:Repository's /vobs/build uuid
is '87701b00.c21e11d5.b323.00:e0:18:1c:4c:3b'
HTTP GETting http://review-board/api/repositories/
HTTP GETting http://review-board/api/repositories/4/
HTTP GETting http://review-board/api/repositories/4/info/
DEBUG:root:Matching repository
uuid:87701b00.c21e11d5.b323.00:e0:18:1c:4c:3b with
path:/view/izabo-ReviewBoard/vobs/build
DEBUG:root:repository info: Path: /view/izabo-ReviewBoard/vobs/build, Base
path: /view/izabo-ReviewBoard/vobs/build, Supports changesets: False
Uploading diff, size: 499
HTTP POSTing to http://review-board/api/review-requests/140/diffs/:
{'basedir': u'/view/izabo-ReviewBoard/vobs/build'}
Review request #140 posted.
http://review-board/r/140/
====================================================================================
Screenshot 1: The status of the review request AFTER the update
Screenshot 2+3+4: The file diff in the Admin screen
Screenshot 5: The review request after I have added the "Diff Set History"
and "Commit ID" manually to the diff set. Also, the Parent Diff HASH was
also empty and I had to set it as well
Attachments:
AfterUpdateNoChangeInReviewRequest.JPG 133 KB
NoCommitIDandDiffSetHistory.JPG 165 KB
ManuallyAddedCommitIDandDiffSetHistory.JPG 163 KB
ParentDiffHashAlsoMissing.JPG 124 KB
NowItsShown.JPG 139 KB
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.
