Your message dated Sun, 28 Apr 2019 16:33:46 +0000
with message-id <e1hkmkm-000bqb...@fasolo.debian.org>
and subject line Bug#905885: fixed in diffoscope 114
has caused the Debian Bug report #905885,
regarding diffoscope: allow overriding of @skip_unless_tools_exist to fail if
tools are missing
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
905885: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=905885
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: diffoscope
Version: 99
Severity: normal
Dear Maintainers,
diffoscope recommends apktool but apktool is not currently in buster. The
test suite of diffoscope currently passes without error because the tests
that use apktool are decorated with @tool_required('apktool').
Consequently:
* the code paths that use apktool are not being tested in buster
* these tests are not actually passing but ci.debian.net is saying that
the test suite has passed (skipping tests to hide errors isn't the
same as a test passing)
There is clear value in being able to skip tests for the casual user on
another platform or when not interested in diffoscope's abilities in
file formats about which one does not care. For the Debian package,
however, I think every functionality of the Debian package should be
tested in autopkgtest. The current situation does not pick up that apktool
is not installable in buster, for instance, and would not pick up
something like /usr/bin/apktool being renamed.
Perhaps @tool_required could be extended with an "all tools required"
mode such that no tests are skipped or missing tools are a test failure
(or error). An environment variable would work for setting that mode
and that mode used at package build time and in autopkgtest.
BTW other latent bugs here:
* diffoscope has an unsatisfiable recommends
* diffoscope cannot be built in buster (unsatisfiable build-deps,
this is RC)
cheers
Stuart
--- End Message ---
--- Begin Message ---
Source: diffoscope
Source-Version: 114
We believe that the bug you reported is fixed in the latest version of
diffoscope, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 905...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Lamb <la...@debian.org> (supplier of updated diffoscope package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sun, 28 Apr 2019 17:21:46 +0100
Source: diffoscope
Binary: diffoscope
Built-For-Profiles: nocheck
Architecture: source all
Version: 114
Distribution: experimental
Urgency: medium
Maintainer: Reproducible builds folks
<reproducible-bui...@lists.alioth.debian.org>
Changed-By: Chris Lamb <la...@debian.org>
Description:
diffoscope - in-depth comparison of files, archives, and directories
Closes: 871244 874582 888237 905885
Changes:
diffoscope (114) experimental; urgency=medium
.
[ Chris Lamb ]
* Add support for GnuPG "keybox" files. Thanks to Daniel Kahn Gillmor for the
suggestion. (Closes: #871244, reproducible-builds/diffoscope#23)
* Always warn if tlsh module is not available (not just if a specific
fuzziness threshold is specified) to match the epilog of the --help output.
This prevents missing support for file rename detection.
(Closes: #888237, reproducible-builds/diffoscope#29)
* Treat missing tools on Debian autopkgtests as individual test failures by
checking whether a new DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS environment
variable is exported. (Closes: #905885, reproducible-builds/diffoscope#35)
* Require that "-" is explicitly specified to read a single diff from
standard input to avoid non-intuitive behaviour when diffoscope is called
without any arguments. (Closes: reproducible-builds/diffoscope#54)
* Make --use-dbgsym a ternary operator to make it easier to totally disable.
Thanks to Mattia Rizzolo for the suggestion.
* Consolidate on "e" as the aliased exception name.
.
[ Milena Boselli Rosa ]
* Various fixes to the HTML markup to prevent validation warnings/errors:
- Prevent empty values for the "name" attribute name on HTML anchor tags,
and add an "id" to its parent "div" container.
- Fix "table column x established by element 'col' has no cells beginning
in it" warnings.
- Fix "Text run is not in Unicode Normalization Form C".
- Remove the "type" HTML attribute from <style> elements.
.
[ Vibhu ]
* Fail more gracefully when running out of diskspace. (Closes: #874582)
Checksums-Sha1:
5a6c110f42ed54a5911b3c20776159afcbcecdab 4533 diffoscope_114.dsc
a65c8eed454ffb0f76e1114ae73c00f2ed3fdaa6 1117320 diffoscope_114.tar.xz
3a63794ac70b7e080391f9f8d1fb6f24b2f79ed3 130320 diffoscope_114_all.deb
e8b49ddf78da84c37a037864356a55c499f10c5d 6504 diffoscope_114_amd64.buildinfo
Checksums-Sha256:
ce37b6b5eadd8d5ef2c08446ca7deb871797b374d49ed44d30b033aac6f5ee70 4533
diffoscope_114.dsc
16c881bb0716de6c64ccae72bfecf2cd03661dbe9ab3e9d2f87aae7bd524437b 1117320
diffoscope_114.tar.xz
07b4d27401e2838fdcfc7a6d2325eacc3e6626cf08207629bb09181ffe41289f 130320
diffoscope_114_all.deb
3e2e8941377f2e39c04e36cdf25a699350c9fb1cbb396e62e0229b6f4630c964 6504
diffoscope_114_amd64.buildinfo
Files:
d6eaeb7b3b42987396d562ca71347a8c 4533 devel optional diffoscope_114.dsc
30e3014327b8fa46feca7e4129a159e7 1117320 devel optional diffoscope_114.tar.xz
2efdb3d3cd1000bb8d37cf03984dfdea 130320 devel optional diffoscope_114_all.deb
02aa356dbbf27fa33fe1cd88c59aa57d 6504 devel optional
diffoscope_114_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlzF02YACgkQHpU+J9Qx
Hli4rBAAtPEbuXpm68kPLdoWI63CLVa1aazyxCyrpzE4/TiwvuEY8t7MYCWYIACB
a6wyf+BL72pQUW1Gju6R+UHST0uJRN9O5NopuXPejaiyQN+9dQThh/SSaKlAzeyI
3CMoIp3JJsUaAbqJoscvF+l5yLeq+4ogEXhz75ru+UbLwtybnzxPp5bnqHLXI89M
+Vx5eE1TvpoIkEsBP90TSRqGd5t5yFN+jY1tGxyt9e7x8S3p/66nC6ub3U4LDRAk
wUd96hStAv2l690kJFL8/2mkGm1pQvtNovLlYTI4ZDSEZi9uleuKHGlu99uXeZyo
6wMjjMyJbkymQIREssfxgRL3jYW7RCDSsuzU88s19NJKqo7RVMqzWnJCuX84xr2h
WJtbCz+bYH539XEADU4fScMD7iinRv44qd7HCFvsvQrnGQZ++++I5+u9UcVGdS3u
hn7ZaTKn7n77EqdGlLOLW1UgGKnFDVr4HMbsg/OiF419ye0lHUuA/avawKN32AnI
6dnXsNPi2avt7pDGFdLiYVOCyYnZZ6VYy4wPf/I2Dqkl04cYZylWPIc7+SlSA2F/
PgkJNRth0Z9GjNQEStAgWZ+8d/wbWWzgVv6MSz5t/ueJVPsktvnaftBXcxE5Jv9C
bLvzTWhrDlD2XuIZBepe3EA1j1zfKwWA5AK4OpSjvo6i1fZbgfw=
=V/if
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/reproducible-builds
