Hello packagers,
*.tar.xz files are available at the usual "stable" location.
*** ATTENTION ***
The 'kdenlive' 18.08 branch was recently found to be broken on some
distributions. Depending on how the shared data paths are setup, the
kdenlive application would fail finding the profiles. A fix was
committed, but I could not yet test the change (see attachment).
Please check if this version works (does not show the "missing profiles"
dialog).
Please report issues, release is next Thursday.
REVISIONS_AND_HASHES at https://paste.kde.org/pxhzzuptm
Preliminary changelog v18.08.2..v18.08.3:
https://www.kde.org/announcements/fulllog_applications.php?version=18.08.3
My public key at
http://pgp.mit.edu/pks/lookup?op=get&search=0xF23275E4BF10AFC1DF6914A6DBD2CE893E2D1C87
Thanks,
Christoph Feck
--- Begin Message ---
Hello,
I just came back home and tried to fix the problem,
can you please check it works on OpenSuse?
Sorry for committing in 2 times, shame on me /o\
Le dimanche 4 novembre 2018 14:19:34 CET, vous avez écrit :
> Hi Vincent,
>
> read inline comment below.
>
> On 23.10.2018 23:18, Vincent PINON wrote:
> > Git commit d8fae4d6419cb9548979ed04c6f4f3403553a93b by Vincent PINON.
> > Committed on 23/10/2018 at 20:53.
> > Pushed by vpinon into branch 'Applications/18.08'.
> >
> > Fix MinGW build
> >
> > M +5 -1 CMakeLists.txt
> > M +58 -54 packaging/kdenlive-msys2.sh
> > M +20 -15 src/CMakeLists.txt
> > M +3 -2 src/main.cpp
> > M +4 -15 src/mltconnection.cpp
> >
> > https://commits.kde.org/kdenlive/d8fae4d6419cb9548979ed04c6f4f3403553a93b
> [...]
> > diff --git a/src/mltconnection.cpp b/src/mltconnection.cpp
> > index b6f9f1f06..43393dea2 100644
> > --- a/src/mltconnection.cpp
> > +++ b/src/mltconnection.cpp
> > @@ -9,7 +9,7 @@ the Free Software Foundation, either version 3 of the
> > License, or
> > (at your option) any later version.
> > */
> >
> > -#include "mlt_config.h"
> > +//#include "mlt_config.h"
> > #include "mltconnection.h"
> > #include "kdenlivesettings.h"
> > #include "core.h"
> > @@ -41,30 +41,19 @@ MltConnection::MltConnection(const QString &mltPath)
> > void MltConnection::locateMeltAndProfilesPath(const QString &mltPath)
> > {
> > QString profilePath = mltPath;
> > - if (!KdenliveSettings::mltpath().isEmpty() &&
> > QFile::exists(KdenliveSettings::mltpath())) {
> > - return;
> > - }
> > if (profilePath.isEmpty() || !QFile::exists(profilePath)) profilePath
> > = qgetenv("MLT_PROFILES_PATH");
> > if (profilePath.isEmpty() || !QFile::exists(profilePath)) profilePath
> > = qgetenv("MLT_DATA") + QStringLiteral("/profiles/");
> > if (profilePath.isEmpty() || !QFile::exists(profilePath)) profilePath
> > = qgetenv("MLT_PREFIX") + QStringLiteral("/share/mlt/profiles/");
> > -#ifdef Q_OS_WIN
> > - if (profilePath.isEmpty() || !QFile::exists(profilePath)) profilePath
> > = qApp->applicationDirPath() + QStringLiteral("/share/mlt/profiles/");
> > -#else
> > - if (profilePath.isEmpty() || !QFile::exists(profilePath)) profilePath
> > = KdenliveSettings::mltpath();
> > - // build-time definition
> > - if ((profilePath.isEmpty() || !QFile::exists(profilePath)) &&
> > !QStringLiteral(MLT_DATADIR).isEmpty()) profilePath =
> > QStringLiteral(MLT_DATADIR) + QStringLiteral("/profiles/");
> > -#endif
> > + if (profilePath.isEmpty() || !QFile::exists(profilePath)) profilePath
> > = qApp->applicationDirPath() + QStringLiteral("/../share/mlt/profiles/");
>
> Here, removing the non-Q_OS_WIN case broke on my system (openSUSE).
> It asks for a path to profiles, but neither entering
> '/usr/share/mlt-6/profiles/' nor '/usr/share/kdenlive/profiles/' makes
> it happy.
>
> Could you check if the case needs to be restored or otherwise adapted?
>
> > KdenliveSettings::setMltpath(profilePath);
> >
> > #ifdef Q_OS_WIN
> > - QString meltPath = QDir::cleanPath(profilePath +
> > QStringLiteral("../../../melt.exe"));
> > + QString meltPath = QDir::cleanPath(profilePath +
> > QStringLiteral("../../../bin/melt.exe"));
> > #else
> > QString meltPath = QDir::cleanPath(profilePath +
> > QStringLiteral("../../../bin/melt"));
> > +#endif
> > if (!QFile::exists(meltPath)) meltPath = qgetenv("MLT_PREFIX") +
> > QStringLiteral("/bin/melt");
> > - if (!QFile::exists(meltPath)) meltPath =
> > KdenliveSettings::rendererpath();
> > if (!QFile::exists(meltPath)) meltPath =
> > QStandardPaths::findExecutable("melt");
> > - if (!QFile::exists(meltPath)) meltPath = QStringLiteral(MLT_MELTBIN);
> > -#endif
> > KdenliveSettings::setRendererpath(meltPath);
> >
> > if (meltPath.isEmpty()) {
> >
>
> Thanks,
> Christoph
>
>
--- End Message ---
