Thanks for the detailed answer Iwan. I certainly would not try to fix the warnings or xfails yet, not being familiar with the codebase. It was more caution of not wanting to add anything that has unintended consequences somewhere else which was not testable.
So the test suite is very comprehensive, but needs a more elaborate environment than a simple test run, understood. Will have a look at the Github actions to try and figure out how to duplicate that locally. On Mon, 15 Aug 2022 at 19:42, Iwan Aucamp <aucam...@gmail.com> wrote: > On Wednesday, 3 August 2022 at 16:18:36 UTC+2 epost...@gmail.com wrote: > >> >> We are open to all PRs that address any problems in RDFLib, so if you > want to fix the warnings or xfails we would be very happy, but it would be > best to address the problems one at a time, not to try and do it all in one > PR. Many problems are not that simple to fix though. A lot of the xfails > (maybe 1/2) are actually because RDFLib is too lax in parsing, and the W3C > test suites which run as part of our test suite requires more strict > behaviour. This is not a simple problem to address, as we should provide > parsers that can be both strict and lax depending on user preference, and > it is also not a high priority problem, if we just made our parsers more > strict most users will be unhappy. > -- http://github.com/RDFLib --- You received this message because you are subscribed to the Google Groups "rdflib-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to rdflib-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/rdflib-dev/CAC%3DqKDHPgv-skvQqn33bjgR8rGQ%3DA-JvePXSgKXvHr1_%2BB_isg%40mail.gmail.com.
