Hi Miel, I think all reviews and approvals are valuable data points, however they will likely all be treated with something not entirely unlike bayesian inference by maintainers. If I as a maintainer see an approval from someone I don't know I will likely not value it much, but if they pointed out valid problems and gave good suggestions to a pull request this will also increase the value that I as a maintainer assigns to an approval from the reviewer. It will likely take some time to gain trust, but that is not a good reason to not try.
Some considerations: - Not every comment on a PR has to be coupled with a review outcome (approval, request for changes, etc) - comments can just be comments. - You should not approve PRs unless you have very high confidence in them, because of this your python skill level does not really matter as long as you know what you do not know and do not assume things without being sure. - Don't be afraid to ask questions in a PR. So in summary, please do review PRs if you have capacity for it, approving a PR will not necessarily mean that maintainers will have high confidence in it, but they will have higher confidence than if nobody else approved. And your python skill should not be an impediment and reviewing PRs will definitely help you increase your python skill level. Regards Iwan Aucamp On Tuesday, 23 November 2021 at 08:59:52 UTC+1 [email protected] wrote: > Hi all, > > Happy to help, but I'm still very much a python newbie. Don't know if > that's helpful? > > Skills aside: is there any guidance on the rdflib governance, or perhaps > soneone should write some contibutor/reviewer guidelines (without becoming > too demanding)? > > Best, > > Miel > > Op di 23 nov. 2021 om 08:55 schreef Nicholas Car < > [email protected]>: > >> Thanks for the offer Donny and we do remember you! I’ll tag you on a >> couple of PRs and whenever you’re available we’d love to have more of your >> input. >> >> Great to see another course unsung RDFlib out there! I used RDFlib + >> Mongo for my very first RDFlib-based system back in, I think 2013! It was >> pretty simple but used the ease of Mongo to store JSON with RDFLib’s >> JSON-Lad capability to store RDF docs. >> >> Perhaps you could make a Mongo back-end Store for RDFlib? >> >> Cheers, >> >> Nick >> — >> Dr Nicholas Car >> Data Systems Architect >> SURROUND Australia >> 0477 560 177 >> [email protected] >> >> On 18 Nov 2021, at 6:12 am, Donny Winston <[email protected]> wrote: >> >> >> Thank you, Iwan. >> >> Feel free to `/cc @dwinston` on PRs you look over and would like another >> set of eyes on. I'll try to do what I can. You may remember me from >> https://github.com/RDFLib/rdflib/pull/1456 a few weeks ago. :) >> >> I won't have much bandwidth over the next couple months, but by ~March >> 2022 I expect to be very interested in more active involvement with RDFLib >> (I have even been putting together a mini course >> <https://github.com/polyneme/intro-linkeddata-mongo-python> using it). >> >> Best, >> Donny >> >> On Wed, Nov 17, 2021, at 2:44 PM, Iwan Aucamp wrote: >> >> I have been thinking more about what we can do, to get more people >> involved with RDFLib. >> >> I really want to see RDFLib get better and be something which people feel >> comfortable in using in production, and for this a higher velocity is >> needed to clear out the issue backlog and keep contributors engaged. >> >> Python is one of the most popular languages in the world and the >> accessibility of RDF on python greatly affects the viability of RDF. >> >> There are a couple of non RDFLib affiliated python projects related to >> RDF, and I think one options is to reach out to the people from those >> libraries and see if they are willing to at the very least do some reviews >> on PRs. >> >> I will reach out to some of them and see if there is any interest. >> On Thursday, 28 October 2021 at 19:37:20 UTC+2 Iwan Aucamp wrote: >> >> Hi, >> >> Currently Nicholas is doing most reviews and approvals, but he is only >> one person. I try and help out with reviews when I can but it would be nice >> if we could have some more people who actively do reviews as I think this >> is currently what holds progress back most and ideally this should not just >> rely on one or two people. If anyone has capacity and availability for >> helping process pull requests do consider helping out, I'm willing to do >> reviews on other repos in exchange. >> >> Regards >> Iwan Aucamp >> >> >> -- >> http://github.com/RDFLib >> --- >> You received this message because you are subscribed to the Google Groups >> "rdflib-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/rdflib-dev/06c47560-17e6-49da-b9b2-30483e4bb303n%40googlegroups.com >> >> <https://groups.google.com/d/msgid/rdflib-dev/06c47560-17e6-49da-b9b2-30483e4bb303n%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> >> -- >> Donny Winston, PhD (he/him/his) | Polyneme LLC >> https://donnywinston.com | https://polyneme.xyz >> >> If I've emailed you, I'd love to speak with you. >> Schedule a meeting (15min+): https://meet.polyneme.xyz >> >> -- >> http://github.com/RDFLib >> --- >> You received this message because you are subscribed to the Google Groups >> "rdflib-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/rdflib-dev/3a3f3cbd-c69c-43c0-8b46-a58550e5a050%40www.fastmail.com >> >> <https://groups.google.com/d/msgid/rdflib-dev/3a3f3cbd-c69c-43c0-8b46-a58550e5a050%40www.fastmail.com?utm_medium=email&utm_source=footer> >> . >> >> -- >> http://github.com/RDFLib >> --- >> You received this message because you are subscribed to the Google Groups >> "rdflib-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> > To view this discussion on the web visit >> https://groups.google.com/d/msgid/rdflib-dev/E0D996C9-E439-4B79-920E-8242EB3859EE%40surroundaustralia.com >> >> <https://groups.google.com/d/msgid/rdflib-dev/E0D996C9-E439-4B79-920E-8242EB3859EE%40surroundaustralia.com?utm_medium=email&utm_source=footer> >> . >> > -- http://github.com/RDFLib --- You received this message because you are subscribed to the Google Groups "rdflib-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/rdflib-dev/df9c94e9-cac9-4211-8597-4db39c2cf970n%40googlegroups.com.
