Antoine Busque <antoinebus...@gmail.com> writes:
> On Mon, Jul 3, 2017 at 11:58 PM, Jeremie Courreges-Anglas
> <j...@wxcvbn.org> wrote:
>>
>> [...]
>>
>> I like the idea, however... why the show_frame_indicator(0) ->
>> show_frame_indicator(1) changes below?
>>
>> Right now, if the focus{up,down,left,right} commands can't find an
>> appropriate frame, they'll stay silent if you are on a single-frame
>> screen. I think it's nicer that way.
>>
>> The rest of the patch looks correct, but I think there is room to
>> simplify the handling of the frame indicator. Could you please test
>> the diff below and report back?
>>
>
> You're right, I just tested that patch on my end and it works just as
> well, with the added bonus of being more consistent with existing
> ratpoison commands' behaviour of not displaying the frame indicator
> when staying on a single-frame screen.
>
> I definitely think you should merge your patch rather than mine.I've just pushed this change on the master branch. Thanks a lot, -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
signature.asc
Description: PGP signature
_______________________________________________ Ratpoison-devel mailing list Ratpoison-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/ratpoison-devel
