@aNsHuL5217 commented on this pull request.
> @@ -33,14 +33,37 @@ $(function () {
map.touchZoomRotate.disableRotation();
map.keyboard.disableRotation();
- $("[data-user]").each(function () {
- const user = $(this).data("user");
- if (user.lon && user.lat) {
- OSM.MapLibre.getMarker({ icon: "dot", color: user.color })
- .setLngLat([user.lon, user.lat])
- .setPopup(OSM.MapLibre.getPopup(user.description))
+ const markerObjects = $("[data-user]")
+ .map(function () {
+ const { lat, lon, color, description } = $(this).data("user");
+
+ if (!lat || !lon) return null;
I added a `.filter()` step before the map to check for valid `lat` and `lon`
data.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6654#discussion_r2665978372
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6654/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
