aNsHuL5217 left a comment (openstreetmap/openstreetmap-website#6616)

@pnorman I gave the `@"foo'` edge case a shot, but getting it to work safely 
(without breaking URLs or HTML) made the regex extremely complex and unreadable.

I'm thinking of sticking with the simpler implementation. In my opinion, the 
trade-off of having hard-to-maintain code isn't worth it for such a rare edge 
case. The current version handles all standard and smart quotes correctly.

I've reverted to the cleaner version—let me know if you're okay with this 
approach!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6616#issuecomment-3677984616
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6616/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to