@hlfan commented on this pull request.


> +                          .uniq
+                          .filter_map do |target|
+      r = RichText.new("text", "foo #{target} bar")
+      links = Nokogiri::HTML::DocumentFragment.parse(r.to_html).css("a")
+      target if links.empty?
+    end
+    key_links = WIKI_PAGES.values
+                          .flat_map { |l| l["key"]&.keys }
+                          .filter { |key| key && !%r{\*:|/|\*$}.match?(key) }
+                          .map { |l| "#{l}=*" }
+                          .uniq
+                          .filter_map do |target|
+      r = RichText.new("text", "foo #{target} bar")
+      links = Nokogiri::HTML::DocumentFragment.parse(r.to_html).css("a")
+      target if links.empty?
+    end

> causing the fan to kick off

unacceptable!
Would you say one assertion per selectively allowed Unicode code block is 
enough?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6612#discussion_r2631513705
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6612/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to