pablobm left a comment (openstreetmap/openstreetmap-website#6606)

> The control should be on the "edit profile" page, not on the profile itself. 

That makes sense, but I'm not sure what this would look like. Currently users 
arrive at the edit section via:
- "Edit Profile Details" which expands buttons that link to the respective edit 
interfaces.
- "Edit Description" which is in place of the description and also leads to the 
corresponding edit interface.

What would be a good way to adapt this convention to the heatmap? @1ec5 
suggests a button. Perhaps a new "Edit heatmap" (?) button under the heatmap, 
linking to the a page showing this checkbox+submit?

> The UserPreference system is really just there as an API, (...) (b)ut I admit 
> that's not really borne out in practice

What I had in mind was the "dark mode" preferences as introduced at 
https://github.com/openstreetmap/openstreetmap-website/pull/6492. Do you think 
we should be introducing a new column in the `users` table? I guess columns are 
cheap but it feels strange to me, particularly if over time we continue 
adding/removing preferences.

> I think there's no need for anything other than the website to read/write 
> this particular option

There has been discussion on GDPR-adjacent topics about how the API is not able 
to provide access to certain things like confirmation of Terms of Use. I wonder 
if we should start designing things like this in a way that allows for API 
clients to access these in the future?

> Should this be visible to moderators too?

That makes sense. I'm going to change this to admins+moderators as per 
@tomhughes comment below.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6606#issuecomment-3645747058
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6606/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to