@tomhughes commented on this pull request.


> @@ -0,0 +1,77 @@
+//= require maplibre-gl/dist/maplibre-gl
+
+OSM.Mapnik = {

Do we maybe want to put this in a sub-namespace of OSM in anticipation of 
having additional layers there?

Maybe even `OSM.Maplibre` that this file can own and which contains 
`Styles.Mapnik` and `getMarker` and `getPopup` functions and the `Locale` and 
`CombinedControlGroup` names as well?

> @@ -0,0 +1,77 @@
+//= require maplibre-gl/dist/maplibre-gl
+
+OSM.Mapnik = {
+  version: 8,

Is there some significance to that choice of version?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6504#pullrequestreview-3568364523
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6504/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to