@tomhughes commented on this pull request.
> @@ -4,7 +4,7 @@
<div class="mb-3 border-bottom border-secondary-subtle pb-3">
<p class="fs-6 overflow-x-auto" dir="auto">
- <%= linkify(@changeset.tags["comment"].to_s.presence ||
t("browse.no_comment")) %>
+ <%= RichText.new("text", @changeset.comment || t("browse.no_comment")) %>
The previous question about `browse.no_comment` applies here as well.
> @@ -8,11 +8,7 @@
</h4>
<p class="fs-6 overflow-x-auto mb-2" dir="auto">
- <% if common_details.changeset.tags["comment"].present? %>
- <%= linkify(common_details.changeset.tags["comment"]) %>
- <% else %>
- <%= t "browse.no_comment" %>
- <% end %>
+ <%= RichText.new("text", common_details.changeset.comment ||
t("browse.no_comment")) %>
Do we need to put the `browse.no_comment` resource through the rich text
processor, or through `linkify` as the initial commit does?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6597#pullrequestreview-3556166803
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6597/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
