@1ec5 commented on this pull request.
These changes make the existing donation link redundant. The link in map
attribution is already obscure, so removing it shouldn’t break anyone’s muscle
memory too bad.
https://github.com/openstreetmap/openstreetmap-website/blob/7fdee463c76c1cbb07f9392986950674bc05edb8/config/layers.yml#L7-L10
Without any additional attribution string, the attribution code needs to be
optional:
https://github.com/openstreetmap/openstreetmap-website/blob/7fdee463c76c1cbb07f9392986950674bc05edb8/app/assets/javascripts/leaflet.map.js#L62-L64
> Yay, another button in the navbar, and there's already a community thread
> asking for a link to community there as well..
There’s some discussion in #6517 and #6575 about opportunities to consolidate
existing navbar items so we don’t end up with a confusingly long list. Even if
the navbar isn’t the perfect place for a donation link, it’s still a much
better place than an attribution line that only sometimes appears on the map.
> @@ -61,6 +61,9 @@
<li class="nav-item">
<%= link_to t("layouts.help"), help_path, :class =>
header_nav_link_class(help_path) %>
</li>
+ <li class="nav-item">
+ <%= link_to t("javascripts.map.make_a_donation"), donate_path, :class
=> header_nav_link_class(donate_path) %>
The localizable string no longer has anything to do with map JavaScript, so we
should replace it with one right next to the “Help” string in en.yml.
> @@ -0,0 +1,3 @@
+<% content_for :content do %>
+ <%= tag.iframe "", :frameBorder => 0, :id => "donate-embed", :class =>
"w-100 vh-100", :autofocus => true, :src =>
t("site.copyright.legal_babble.lead_2_making_donation_url") %>
Should the donation page URL even be localizable? I think there’s only one
version of the page, which should be hard-coded or moved to config/settings.yml
and referenced through `Settings`.
> @@ -0,0 +1,3 @@
+<% content_for :content do %>
+ <%= tag.iframe "", :frameBorder => 0, :id => "donate-embed", :class =>
"w-100 vh-100", :autofocus => true, :src =>
t("site.copyright.legal_babble.lead_2_making_donation_url") %>
> Seriously though if you want to propose a link to the donation site then just
> do that - framing the site is just going to be horrible.
The iframe is probably in response to the concern in
https://github.com/openstreetmap/openstreetmap-website/issues/3041#issuecomment-769873636
about taking the user away from the main site’s navigation, making it harder
for the user to come back. On the other hand, the supporting site’s homepage
isn’t optimized for being embedded in this site. There’s also at least one link
to OSM that will cause this site to nest within itself.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6600#pullrequestreview-3554636919
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6600/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
