tomhughes left a comment (openstreetmap/openstreetmap-website#6588)
So the database healthcheck thing doesn't look unreasonable but I can't
actually find any failing cases that look like they are caused by the database
being ready so I'd be interested to know what made you think it was an issue?
You've also extended the (recently introduced) timeout for the job from 20
minutes to 40 minutes - do you have some cases in mind where the current
timeout was too short?
Finally you've added a couple of retry loops with no real explanation of why
you think they're a good idea - if `docker build` fails once why would think
you think running it a second time would help? That suggests that transient
failures of some sort are common - do you have an example of that? Ideally the
solution to such things is to try and fix the transient failures not to work
around them with a retry loop.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6588#issuecomment-3611101441
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6588/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
