gravitystorm left a comment (openstreetmap/openstreetmap-website#6583)

> Looks good to me 👍 What are the edge cases?

* We use `·` in various places, but that's not in the erb_lint entity 
ignore list. See also https://github.com/Shopify/erb_lint/pull/397 
* erb_lint gets confused when attempting to parse 
https://github.com/openstreetmap/openstreetmap-website/blob/acb1e73fa98e6cb7adf67f99e0be5891dcd4f6ea/app/views/browse/_relation.html.erb#L27-L35
 - it ends up thinking that `src=` is text content instead of an html 
attribute. It might be possible to refactor that to be more parser friendly 
(and maybe easier for me to read too!), or we just ignore that file.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6583#issuecomment-3607652886
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/6583/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to