@tomhughes commented on this pull request.
This mostly looks pretty good to me - possibly we should add something at some
point about what we consider "in scope" to try and avoid people spending time
on out of scope features though.
> + your needs well, and frames them in the context of the wider community.
+- **Code reviews:** at any given point, there will be pending PRs, waiting for
+ reviews. Can you take on one, understand what it's trying to do, and
+ provide actionable feedback? Is the code clear, maintainable, and readable?
+ Would you do something differently? Are useful, clear tests provided?
+- **Code:** take an existing issue and try to fix it, or try to implement
+ an idea.
+- And probably other ideas not captured here.
+
+Bear in mind that OSM attracts very diverse contributors with very different
+needs. Others may have needs different from yours, and reaching a consensus
+is sometimes difficult.
+
+If you want to code a feature to this repository, we recommend that you ask
+for feedback early and often. Create an issue to discuss it, or start with a
+Draft PR that shows your intention clearly and can be used to provide early
Should `Draft` be capitalised here? There's another use of the phrase later
that isn't...
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6543#pullrequestreview-3506513622
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6543/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
