pablobm left a comment (openstreetmap/openstreetmap-website#6555)
I gather that this is about the discussion at
https://github.com/openstreetmap/openstreetmap-website/issues/3532. @anant2526,
please make sure to reference previous discussions so that we can tell the
context better. I see that you put the issue number in the PR title, but that's
easy to miss.
You are providing an HTML document, but this doesn't automatically work. It
needs to be integrated in the application correctly. I did a quick fix at
https://github.com/openstreetmap/openstreetmap-website/compare/master...pablobm:openstreetmap-website:404-page,
but it's still not good enough. It needs to follow the template and layout
conventions, like the current error page does. See
[app/views/errors/not_found.html.erb](https://github.com/openstreetmap/openstreetmap-website/blob/a2d0762f2a4499e7ddcbc6dde29bac847c249024/app/views/errors/not_found.html.erb).
If you are new to Ruby on Rails, I recommend you read the documentation (eg:
https://guides.rubyonrails.org/layouts_and_rendering.html).
As for the design itself, it looks nice but it has issues. For example the text
is not visible in small screens:
Current | This PR
--- | ---
<img width="465" height="833" alt="404-mobile-current"
src="https://github.com/user-attachments/assets/5ec7e3be-7c00-4224-baac-b9fbf9f48ee4";
/> | <img width="467" height="831" alt="404-mobile-pr"
src="https://github.com/user-attachments/assets/a85ad638-1a6b-4602-bea9-5513ce43033a";
/>
I recommend that you look into how we use Bootstrap in this application, as it
has features to help with responsive design.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6555#issuecomment-3562857192
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6555/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
