1ec5 left a comment (openstreetmap/openstreetmap-website#6448)
> the unchanged values appear with a grey background
This means a version that only changes geometry will have a completely
grayed-out table. I think it could help visually differentiate the history page
from the version page.
> Apologies for the late comment but I don't see additional discussion about
> this. I am confused about the `<del>`/`<ins>` approach having been abandoned,
> since the removed parts are pretty evident with the strikethrough formatting,
> and as for the new parts, CSS could be used to omit the underlining, since
> the absence of strikethrough should be enough to distinguish the old vs. new
> values.
Do you suggest using `<del>` and `<ins>` tags in addition to the + and −
indicators? Or do you mean we should return to inlining a changed tag, using
`<del>` and `<ins>` to distinguish old and new values? Inlining could be useful
if we later introduce per-word or per-character diffing, to make subtle changes
easier to spot. If so, I agree with using CSS to nix the underline.
Without that more granular diffing, this more structured design would be more
effective at highlighting subtle changes. If we keep it, we should still make
the + and − indicators more screen reader accessible: wrap each of these
symbols in a `<abbr title>` tag that the screen reader can expand to something
like “Removed” or “Added”.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6448#issuecomment-3539665662
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6448/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
