hlfan left a comment (openstreetmap/openstreetmap-website#3815)
I've recently found myself reviewing less frequently — not because I expected
progress on particularly my submissions in return, but because I didn't see my
reviews contributing meaningfully to overall progress.
A big part of that, I think, comes down to differing review criteria between
contributors and maintainers. That’s fair to some extent, but it becomes
frustrating when a maintainer fast-tracks their PR that renders an earlier,
unreviewed PR obsolete — without any discussion or acknowledgment of the
overlap. It feels dismissive to those who spent time contributing and reviewing.
It’s even more disheartening when follow-up questions on concerns go unanswered
— especially when the one maintainer who raised them refuses to elaborate. In
those cases, it feels like the PR is being silently closed off, without the
transparency that a clear rejection or actionable feedback would bring.
I too think a guide — covering both obvious and not-so-obvious things to look
out for during reviews — could help align reviews. That might even encourage
maintainers to comment on areas they’d otherwise leave to another.
Another underused tool is labeling: opening that feature up to more
contributors could help with navigating the sea of issues and PRs.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3815#issuecomment-3058380541
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/3815/3058380...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
