@tomhughes commented on this pull request.
> @@ -33,7 +34,7 @@ def index
elsif current_user && current_user == target_user
t ".my_gps_traces"
else
- t ".public_traces_from", :user => target_user.display_name
+ t ".public_traces_from_html", :user =>
tag.bdi(target_user.display_name)
So I've failed to find out exactly what's going on here but something deep in
the rails output capture magic is going wrong and causing most of the output
inside the `tag.head` block in `app/views/layouts/_head.html.erb` to be output
directly instead of being captured and then wrapped in the tag.
It turns out that `bdi` tags in a title element don't work anyway though as the
browser will just render them as text in the title bar, so I've replaced them
with the equivalent unicode characters which is a trick we already use in
`set_title`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3429#discussion_r2106266400
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/3429/review/2866908...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
