@hlfan commented on this pull request.
> assert_response :success
# The data should not be empty
heatmap_data = assigns(:heatmap_data)
assert_not_nil heatmap_data
assert_predicate heatmap_data[:data], :any?
# The data should be in the right format
- assert(heatmap_data[:data].values.all? { |entry| entry[:date] &&
entry[:total_changes] }, "Heatmap data should have :date and :total_changes
keys")
+ assert(heatmap_data[:data].values.all? { |entry| entry[:date] &&
entry[:total_changes] && entry[:max_id] }, "Heatmap data should have :date and
:total_changes keys")
Do wee need to keep that comment or is "incorrect heatmap data structure"
enough?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5829#pullrequestreview-2854524953
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5829/review/2854524...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
