nertc left a comment (openstreetmap/openstreetmap-website#5439)
PR was updated. `master` was merged. All conflicts were resolved.
PR was changed according to the suggestions.
Only RuboCop error is about the length of the `User` class (this PR added only
2 necessary lines to it). I can change `Metrics/ClassLength` to 623 from 621,
but I think it either should be changed to some meaningful value in the
separate PR (it shouldn't be changed every time `User` class is modified) or
removed completely.
Feel free to suggest further changes related both to the code and RuboCop.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2882941316
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5439/c2882941...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
