@tomhughes commented on this pull request.
> @@ -26,6 +26,10 @@
<% else %>
<%= render :partial => "notes_paging_nav" %>
+ <svg width="0" height="0" class="end-100 position-absolute">
As all three places that include the partial wrap it in the same `svg` element
why not include that in the partial?
> @@ -26,6 +26,10 @@
<% else %>
<%= render :partial => "notes_paging_nav" %>
+ <svg width="0" height="0" class="end-100 position-absolute">
+ <%= render :partial => "layouts/defs_markers", :locals => { :types =>
%w[cross tick] } %>
What's the logic behind `defs_markers` as the name? I assume defs is
definitions or something? I suggest just using `markers` as the name I think.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5854#pullrequestreview-2812545336
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5854/review/2812545...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
