@hlfan commented on this pull request.
> @@ -0,0 +1,7 @@
+json.partial! "api/root_attributes"
+
+json.osmChange do
+ json.create @created.map { |elt| JSON.parse(render(partial:
"api/#{elt.to_partial_path}", object: elt)) }
+ json.modify @modified.map { |elt| JSON.parse(render(partial:
"api/#{elt.to_partial_path}", object: elt)) }
+ json.delete @deleted.map { |elt| JSON.parse(render(partial:
"api/#{elt.to_partial_path}", object: elt)) }
I don't think having the json serialized, parsed and serialized again is the
best way to do this.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5973#pullrequestreview-2809611906
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5973/review/2809611...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
