@tomhughes commented on this pull request.


>      this._highlightLayer.clearLayers();
 
     for (const changeset of this._changesets.values()) {
-      const rect = L.rectangle(changeset.bounds, 
this._getInteractiveStyle(changeset));
+      const rect = L.rectangle(changeset.bounds, 
this._getAreaStyle(changeset));
+      rect.id = changeset.id;
+      rect.addTo(this._areaLayer);
+    }
+
+    for (const changeset of this._changesets.values()) {
+      const rect = L.rectangle(changeset.bounds, 
this._getBorderStyle(changeset));

Can we not add the changeset to both layer groups in the same loop rather than 
doing two passes?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5963#pullrequestreview-2804457481
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5963/review/2804457...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to