@hlfan commented on this pull request.
> $("#referer").val($("#referer").val() + location.hash);
+ $("#referer_link").prop("href", $("#referer_link").prop("href") +
location.hash);
The insistence on using jQuery reduces the legibility:
``` suggestion
$("#referer")[0].value += location.hash;
$("#referer_link")[0].hash = location.hash;
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5957#pullrequestreview-2796456086
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5957/review/2796456...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev