@AntonKhorev commented on this pull request.
> + let distanceUnits = "km";
let downloadURL = null;
- function formatTotalDistance(m) {
- if (m < 1000) {
- return OSM.i18n.t("javascripts.directions.distance_m", { distance:
Math.round(m) });
- } else if (m < 10000) {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance: (m /
1000.0).toFixed(1) });
+ function translateDistanceUnits(m) {
+ if (distanceUnits === "km") {
+ return [m, "m", m / 1000, "km"];
} else {
- return OSM.i18n.t("javascripts.directions.distance_km", { distance:
Math.round(m / 1000) });
+ return [m / 0.3048, "ft", m / 1609.344, "mi"];
}
}
- function formatStepDistance(m) {
- if (m < 5) {
+ function formatTotalDistance(minorValue, minorName, majorValue, majorName) {
+ const scope = "javascripts.directions.distance_in_units";
I wouldn't. You are proposing to store it in a variable which might get
replaced by a cookie.
Also "so the ...translateDistanceUnits(...) can be dropped" = going back on
your previous proposal in
https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2039306783
where you wanted unit conversion taken out of formatters.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5915#discussion_r2058496178
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5915/review/2791283...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
