nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5904)
Updated PR to display how notes versioning, removing special note comments
(ones with non-present body which are not "commented") and versioned note tags
could look like.
Removal of special note-comments (while keeping backward compatibility, i.e.
returning same "discussion" with hopefully similar performances) with
non-present body is implemented by:
- creating a view which "merges" `note_versions` and `note_comments`. I used
this approach to keep note comments preloading etc.,
- switching `.comments` and `.all_comments` associations to point to newly
created view, instead of `NoteComment`,
- removing adding special comment if body is not present
- running migration script which deletes all special note comments with
non-present body.
- After this, we should be able to remove `event` column (still not
implemented).
I would highly appreciate any comment about these changes.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5904#issuecomment-2815829043
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5904/c2815829...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
