@nertc commented on this pull request.


> @@ -2,7 +2,10 @@
   <%= render :partial => "diary_entry_heading", :object => diary_entry, :as => 
"diary_entry" %>
 
   <div class="richtext text-break" xml:lang="<%= diary_entry.language_code %>" 
lang="<%= diary_entry.language_code %>">
-    <%= diary_entry.body.to_html %>
+    <%= truncated ? diary_entry.body.to_html(2000) : diary_entry.body.to_html 
%>
+    <% if truncated && diary_entry.body.was_truncated?(2000) %>

`truncate_html` method was modified to be public and return object containing 
`html` and `truncated` information. To avoid calling method twice and caching 
(e.g. Memoization), truncated object is saved as `truncated_entry` variable in 
the `.html.erb` file.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5121#discussion_r2046777942
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5121/review/2772264...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to