Re: [openstreetmap/openstreetmap-website] Adds version to notes table and creates note_versions table (PR #5815)

[Nenad Vujicic via rails-dev]

nenad-vujicic left a comment (openstreetmap/openstreetmap-website#5815)

> Why do we need versions to sort comments? Comments already have IDs that can 
> be used for ordering them and deleting some of them doesn't change that - a 
> sequence with gaps is just as ordered as one without them...

Yes, but we want to keep backward compatibility and display (return in JSON / 
XML) special comments (reconstructed from `note_version` about closing, 
reopening, hiding, ..) too even if their body is non-present (like on the 
screenshot) in appropriate order. If we can abandon these special comments, we 
wouldn't need `note_comment_id`.

![image](https://github.com/user-attachments/assets/94d38de4-0b65-42f8-ac75-db07e8470df0)


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5815#issuecomment-2807611754
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5815/c2807611...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev