@AntonKhorev commented on this pull request.
> + <p><%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon =>
> tag.a(render(:partial => "layouts/note_icon"),
+
:class => "icon note",
Continuing
https://github.com/openstreetmap/openstreetmap-website/pull/5752#discussion_r2021990094
Do you still think you need map control icons in three different places as
opposed to one, which you could use like this:
```suggestion
<% note_icon = capture do %>
<%= tag.a :class => "icon note", :title =>
t("javascripts.site.createnote_tooltip") do %>
<svg width="20" height="20"><use href="#icon-note" /></svg>
<% end %>
<% end %>
<p><%= t ".how_to_help.add_a_note.instructions_1_html", :note_icon =>
note_icon %></p>
```
(this is ignoring that you changed how this link looks)
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#pullrequestreview-2762170694
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5752/review/2762170...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
