@AntonKhorev commented on this pull request.
> YAML.load_file(Rails.root.join(layers_filename))
.reject { |layer| layer["apiKeyId"] && !Settings[layer["apiKeyId"]] }
.map do |layer|
if layer["apiKeyId"]
layer["apikey"] = Settings[layer["apiKeyId"]]
layer.delete "apiKeyId"
end
+ layer["hasKey"] = true if keys&.include?(layer["layerId"])
The word "key" is overused. "hasKey" - which key? Here it's right next to
another entirely different "key".
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5918#pullrequestreview-2762134064
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5918/review/2762134...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
