@AntonKhorev commented on this pull request.


>      end
   end
 
+  def wrap_lon(lon)
+    ((lon + 180) % 360) - 180

> I don't think this works?

There are branches for "nonsense" cases.

> If we consider a range from -270 to 270 and apply this to both then we wind 
> up with 90 to -90 which is clearly nonsense?

```
elsif db_min_lon > db_max_lon
```

> Even considering a simple globe spanning -180 to 180 wraps both to -180 
> leaving us with an empty box...

```
if max_lon - min_lon >= 360
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5473#discussion_r2032476628
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5473/review/2748804...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to