Look at data layer. Notice that everything is blue:
![image](https://github.com/user-attachments/assets/219698eb-5124-44a7-b133-c12bf8c3e8f0)

Now look at the `setStyle` call that I remove in this PR. Notice that the 
colors are supposed to be black, red, green. It's broken since 
https://github.com/openstreetmap/openstreetmap-website/commit/5e9ab5bc5edb63b7ab7719fa989a18f52e3637a2,
 but I'm not fixing it because those colors don't look very well over 
the tiles and everyone probably got used to blue.

The argument to `setStyle` is invalid; and when used on feature group layer, 
`setStyle` should be called after adding the geometry.
https://leafletjs.com/reference.html#featuregroup-setstyle
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5892

-- Commit Summary --

  * Remove invalid setStyle from data layer

-- File Changes --

    M app/assets/javascripts/index/layers/data.js (15)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5892.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5892.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5892
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to