We use TagHelper module to convert `:rel => "nofollow noopener 
noreferrer"` into `'rel="nofollow noopener 
noreferrer"'`, probably because 
[Rinku](https://github.com/vmg/rinku)'s readme says thet we can generate an 
attribute string from a hash. And to do that we have to call what is now a 
private method of TagHelper; maybe it wasn't private when the readme was 
last updated.

Or we could just write a string.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5850

-- Commit Summary --

  * Remove TagHelper include from RichText module

-- File Changes --

    M lib/rich_text.rb (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5850.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5850.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5850
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to