@tomhughes requested changes on this pull request.


> @@ -3,6 +3,10 @@ def self.full_definitions(layers_filename)
     YAML.load_file(Rails.root.join(layers_filename))
         .reject { |layer| layer["apiKeyId"] && !Settings[layer["apiKeyId"]] }
         .map do |layer|
+          layer["name"] = I18n.t("site.index.map.base.#{layer['nameId']}")

We can't do the translations like this because this will get run when `osm.js` 
is built from `osm.js.erb` which only happens once, not once per language.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5832#pullrequestreview-2706736373
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5832/review/2706736...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to