Re: [openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

[Anton Khorev via rails-dev]

AntonKhorev left a comment (openstreetmap/openstreetmap-website#5752)

> Matching the active button behaviour in 
> [bc50867](https://github.com/openstreetmap/openstreetmap-website/commit/bc508673e788ce8c00cf2f030261f733184c2177)
>  was intentional, that's why I split it into a separate commit.

I asked if you wanted to change how this button looks when active. Did you want 
to change how this button looks?

> But changing the foreground color instead of the background color for 
> locating, querying and notating can be done by changing this line alone:
> 
> https://github.com/openstreetmap/openstreetmap-website/blob/5fbbc4801b6c1e0ed258526f55043bfcc6955d74/app/assets/stylesheets/common.scss#L283

You changed their active background color. Did you want to do it?

![image](https://github.com/user-attachments/assets/db6c6463-d265-4d42-aa30-68da1711dadd)

You removed the green background from some buttons and added it to another 
button.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752#issuecomment-2741940878
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5752/c2741940...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev