@AntonKhorev commented on this pull request.


>            mapParams = {};
 
+    [geoURI.coordstring, ...geoURI.params] = geoURI.pathname.split(";");
+    geoURI.params = Object.fromEntries([...geoURI.searchParams, 
...geoURI.params.map(p => p.split("=").map(decodeURIComponent))]);

Why would you go through this extra effort of merging url and geo parameters? 
How about urls like `geo:59.95121,30.37522;z=ignore?z=15`?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2694339212
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5736/review/2694339...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to