hlfan left a comment (openstreetmap/openstreetmap-website#3123)

> * there is no clue of what the dropdown is for, what OSRM, GraphHopper, and 
> Valhallah are

Do you think an `optgroup` with a `label` and a `title` on the `select` would 
be enough hints?
> * adding a short message to advertise that routing engines are used by the 
> mapper community to ensure the points they add to the map are well connected.

This would need space, where would you put it?
> * the matching locations are not suggested while typing, which likely results 
> in routing beeing calculated for non-expected locations (this might deserve 
> an issue on its own)

Probably, as the Nominatim [usage 
policy](https://operations.osmfoundation.org/policies/nominatim/) prohibits 
autocompleting results, so that can't as easily be added.
> * The close button is a bit too close the reverse directions button and the 
> input form

Sticky close buttons have been introduced since, maybe reusing that style could 
add more separation?
> * pressing the go button during a calculation seemed to break the route that 
> was beeing processed (could not reproduce today though)
> * triggerring the calculation as soon as two locations are selected, a 
> location is changed, the transport mode is changed, or the routing engine is 
> changed
> * removing the go button

Maybe for the sake of having a submit button for accessibility just make it 
hidden, I don't know if that would need to be discussed further.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/3123#issuecomment-2729376115
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/issues/3123/2729376...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to