tomhughes left a comment (openstreetmap/openstreetmap-website#5761)

Did you try doing this via normal ActiveModel queries before resorting to raw 
SQL queries?

I certainly don't like the idea of interpolating arguments into the queries - 
the fact that you called the argument `quoted_user_id` immediately hints at the 
risks of doing so. Is it not possible to use bound parameters with these 
queries?

What analysis have you done of the execution plan(s) and the likely 
performance? Is everything using indexes or are there things which are doing 
table scans?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5761#issuecomment-2715668476
You are receiving this because you are subscribed to this thread.

Message ID: 
<openstreetmap/openstreetmap-website/pull/5761/c2715668...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to