@hlfan commented on this pull request.
> + <% if changeset.comments.empty? %>
+ <path d="M2.678 11.894a1 1 0 0 1 .287.801 11 11 0 0 1-.398
2c1.395-.323 2.247-.697 2.634-.893a1 1 0 0 1 .71-.074A8 8 0 0 0 8 14c3.996 0
7-2.807 7-6s-3.004-6-7-6-7 2.808-7 6c0 1.468.617 2.83 1.678 3.894m-.493
3.905a22 22 0 0 1-.713.129c-.2.032-.352-.176-.273-.362a10 10 0 0 0
.244-.637l.003-.01c.248-.72.45-1.548.524-2.319C.743 11.37 0 9.76 0 8c0-3.866
3.582-7 8-7s8 3.134 8 7-3.582 7-8 7a9 9 0 0
1-2.347-.306c-.52.263-1.639.742-3.468 1.105" />
+ <% else %>
+ <path d="M8 15c4.418 0 8-3.134 8-7s-3.582-7-8-7-8 3.134-8 7c0
1.76.743 3.37 1.97 4.6-.097 1.016-.417 2.13-.771 2.966-.079.186.074.394.273.362
2.256-.37 3.597-.938 4.18-1.234A9 9 0 0 0 8 15" />
+ <% end %>
There's actually no need to define the same path twice
```suggestion
<path d="M8 15c4.418 0 8-3.134 8-7s-3.582-7-8-7-8 3.134-8 7c0
1.76.743 3.37 1.97 4.6-.097 1.016-.417 2.13-.771 2.966-.079.186.074.394.273.362
2.256-.37 3.597-.938 4.18-1.234A9 9 0 0 0 8 15
<% if changeset.comments.empty? %>
M2.678 11.894C1.617 10.83 1 9.468 1 8 1 4.808 4.004 2 8 2s7 2.807
7 6-3.004 6-7 6a8 8 0 01-2.089-.272 1 1 0
00-.71.074c-.387.196-1.239.57-2.634.893a11 11 0 00.398-2 1 1 0 00-.287-.801
<% end %>
" />
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5775#pullrequestreview-2669192655
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5775/review/2669192...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
