#4901 v2
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5753

-- Commit Summary --

  * Separate setting/clearing listeners/values on directions endpoints
  * Move directions params init code to its own function
  * Move directions listeners init code to its own function
  * Write directions sidebar header using .erb template
  * Hide loader spinner when sidebar content is not displayed
  * Move directions title out of javascript i18n strings
  * Use svg symbols for routing icons

-- File Changes --

    D app/assets/images/routing-sprite.svg (55)
    M app/assets/javascripts/index.js (4)
    M app/assets/javascripts/index/directions-endpoint.js (20)
    M app/assets/javascripts/index/directions.js (96)
    M app/assets/javascripts/index/directions/fossgis_osrm.js (50)
    M app/assets/javascripts/index/directions/fossgis_valhalla.js (64)
    M app/assets/javascripts/index/directions/graphhopper.js (32)
    M app/assets/stylesheets/common.scss (21)
    M app/views/directions/search.html.erb (81)
    M app/views/layouts/map.html.erb (2)
    M config/locales/en.yml (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5753.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5753.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5753
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev

Reply via email to