Currently we have in use: - `location` - `window.location` - `document.location`
The only one that's missing is `window.document.location`. These are [mostly the same](https://stackoverflow.com/questions/2430936/whats-the-difference-between-window-location-and-document-location). We can just use `location` everywhere because it's shorter. You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5739 -- Commit Summary -- * Use location instead of window.location and document.location -- File Changes -- M app/assets/javascripts/embed.js.erb (2) M app/assets/javascripts/index.js (4) M app/assets/javascripts/index/changeset.js (4) M app/assets/javascripts/index/directions.js (2) M app/assets/javascripts/index/history.js (8) M app/assets/javascripts/index/note.js (2) M app/assets/javascripts/index/query.js (2) M app/assets/javascripts/leaflet.map.js (4) M app/assets/javascripts/login.js (4) M app/assets/javascripts/matomo.js (2) M app/assets/javascripts/osm.js.erb (2) M app/assets/javascripts/router.js (8) M app/assets/javascripts/welcome.js (4) M test/javascripts/osm_test.js (6) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5739.patch https://github.com/openstreetmap/openstreetmap-website/pull/5739.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5739 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
