@tomhughes commented on this pull request.
> @@ -43,7 +43,7 @@ def show
@note_includes_anonymous = @note.author.nil? || @note_comments.find {
|comment| comment.author.nil? }
- @note_comments = @note_comments.drop(1) if @note.author.nil? ||
@note.author.active?
+ @note_comments = @note_comments.drop(1) if (@note.author.nil? ||
@note.author.active?) && @note.description.present?
Shouldn't this condition just be that we drop the first comment if it's of type
`opened` rather than trying to guess that from other things?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5712#pullrequestreview-2630617545
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5712/review/2630617...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
