@hlfan commented on this pull request.
> + modeGroup.html("");
+ for (const mode of new Set(modes)) {
+ modeGroup.append(`<input type="radio" class="btn-check" name="modes"
id="${mode}" autocomplete="off">`);
+ modeGroup.append(`<label class="btn btn-outline-secondary px-2"
for="${mode}" title="${
+ I18n.t("javascripts.directions.modes." + mode)
+ }"><svg class="d-block" width="16" height="16" fill="currentColor"><path
d="${modeIconPaths[mode]}"></path></svg></label>`);
+ }
Disabling the buttons and the selects options seems better, disabling all in
the template and enabling each in js when supported.
However, I don't want to move too much to be hardcoded like it was already
criticized in
https://github.com/openstreetmap/openstreetmap-website/pull/3400#issuecomment-1057225749
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5652#discussion_r1963036951
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5652/review/2628999...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
