@gravitystorm commented on this pull request.
> @@ -581,6 +581,15 @@ header .search_forms,
}
}
+.search_forms {
We try hard to avoid writing custom CSS for features on the website -
typically, we only use Bootstrap classes applied directly to the elements.
Most existing CSS in this file can be considered a target for refactoring.
> @@ -581,6 +581,15 @@ header .search_forms,
}
}
+.search_forms {
+ .geolocate {
+ transition: filter 0.15s ease-in-out;
We don't use transitions on any other button content, so I don't think it's
necessary here
> @@ -581,6 +581,15 @@ header .search_forms,
}
}
+.search_forms {
+ .geolocate {
+ transition: filter 0.15s ease-in-out;
+ }
+ .btn:not(:hover) .geolocate {
+ filter: brightness(53%);
I can see what this is doing, but I don't think it's the right approach. We
should either:
* Add icons to the spritesheet, with the colours that we want (for light mode,
and dark mode if necessary)
* Or we should take the approach of the "swap directions" button, which has
inline SVG and automatic colouring.
> @@ -11,7 +11,7 @@ OSM.Search = function (map) {
e.preventDefault();
const query = $(this).closest("form").find("input[name=query]").val();
let search = "";
- if (query) search = "?" + new URLSearchParams({ from: query });
+ if (query) search = "?" + new URLSearchParams({ to: query });
This suggested behaviour is very common. I know that because personally it
usually frustrates me - when I'm using other apps and planning to go from A to
B I search for A first, then the site offers direction *to* A, and then I need
to swap start/end points. So that's why I know that `search query` -> `routing
destination` is much more common than `search query` -> `routing origin`.
Overall I'd be in favour of this change, even if it frustrates me, because it's
much more likely that if you search for one place and use the geolocation
button, the searched place is going to be the destination.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5635#pullrequestreview-2627160624
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5635/review/2627160...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
