gravitystorm left a comment (openstreetmap/openstreetmap-website#5670)
> Reporting failed job as success would not be really better in this case.
If I understand correctly, this is not failed jobs but jobs with errors. So if
the job runs, but for example the overall coverage is too low, then the job
will fail and CI will show a failure. But this is different from the job having
an error, for example not being able to connect to coveralls.io.
In short, the coveralls job can return a) success b) failure c) error, and CI
can only be 1) success or 2) failure, and the setting is to choose whether c
== 1 or c == 2
So the setting is to decide whether to handle a coveralls error as a failure
(as now) or as a success. The risk is that the job might error for reasons
under our control (e.g. gem update breaks simplecov) and if it's not causing
failures in CI, we might not notice for a long time.
So my proposal is to keep the setting as it is now (coveralls error == CI fail)
and we can always change this temporarily if there is a problem with coveralls
that we need to work around.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/5670#issuecomment-2661439731
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/5670/2661439...@github.com>
_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
