Addresses #5488 by providing a setting instead of workarounds such as modifying `test/application_system_test_case.rb`.
I'm also using these workarounds and it's annoying because you can accidentally commit them. But if there's a setting, I can put it in some file that's ignored by git, for example in `config/settings/test.local.yml` (assuming tests run in test environment; teaspoon tests by default don't but you can run them with `RAILS_ENV=test bundle exec teaspoon`). You can view, comment on, or merge this pull request online at: https://github.com/openstreetmap/openstreetmap-website/pull/5672 -- Commit Summary -- * Add option to override Firefox binary used in system tests -- File Changes -- M config/settings.yml (2) M test/application_system_test_case.rb (1) M test/teaspoon_env.rb (4) -- Patch Links -- https://github.com/openstreetmap/openstreetmap-website/pull/5672.patch https://github.com/openstreetmap/openstreetmap-website/pull/5672.diff -- Reply to this email directly or view it on GitHub: https://github.com/openstreetmap/openstreetmap-website/pull/5672 You are receiving this because you are subscribed to this thread. Message ID: <openstreetmap/openstreetmap-website/pull/5...@github.com>
_______________________________________________ rails-dev mailing list rails-dev@openstreetmap.org https://lists.openstreetmap.org/listinfo/rails-dev
