@tomhughes commented on this pull request.
>
- noteLoader = null;
+ for (var id in oldNotes) {
+ noteLayer.removeLayer(oldNotes[id]);
+ }
+ })
+ .catch(() => {})
So this is what I wasn't sure about - what happens if a fetch is rejected and
nothing catches the rejection.
If that leads to a message in the console then we should probably have a no-op
catch on all of them? Unless we want network errors to get reported in the
console but in that case the ones that exist to catch aborts should rethrow
other errors?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5669#discussion_r1955178113
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5669/review/2616161...@github.com>_______________________________________________
rails-dev mailing list
rails-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/rails-dev
